Disable the DynamicProxy for ConventionalControllers.

[maliming]

From #18845 (comment)

Because it becomes an MVC controller, it has global filters.

Resolve #18845

[codecov]

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (da59ccb) 51.60% compared to head (2d31fc8) 51.59%.
Report is 6 commits behind head on rel-8.0.

Files	Patch %	Lines
...e/Volo/Abp/DynamicProxy/DynamicProxyIgnoreTypes.cs	0.00%	10 Missing ⚠️
...Abp/AspNetCore/Mvc/ConventionalController_Tests.cs	0.00%	6 Missing ⚠️
...etCore/VirtualFileSystem/WebContentFileProvider.cs	0.00%	3 Missing and 1 partial ⚠️
...Volo.Abp.Core/Volo/Abp/DynamicProxy/ProxyHelper.cs	0.00%	3 Missing ⚠️
.../Abp/TestApp/Application/ConventionalAppService.cs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           rel-8.0   #18874      +/-   ##
===========================================
- Coverage    51.60%   51.59%   -0.02%     
===========================================
  Files         3077     3079       +2     
  Lines        97270    97302      +32     
  Branches      7746     7747       +1     
===========================================
+ Hits         50200    50202       +2     
- Misses       45524    45549      +25     
- Partials      1546     1551       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hikalkan]

@maliming doesn't AppliedCrossCuttingConcerns system already solves the duplication problem?
I am unsure about that change. For example, if we add another interceptor for appservices, we should always also add action filters. Otherwise, the interception logic won't work. Even if we do it for the framework, custom interceptors (added by the application developer) won't work.

[maliming]

We don't apply interceptors for controllers.
https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.Core/Volo/Abp/DynamicProxy/DynamicProxyIgnoreTypes.cs#L7-L14

The Authorization middleware do a check. After that the AuthorizationInterceptor is checked again.

I've only disabled the interceptor for the application service controllers. Because it doesn't inherit from ControllerBase

https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/AbpAspNetCoreMvcModule.cs#L67

[hikalkan]

Thanks for the explanation.