Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remember me implementation #18768

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Add remember me implementation #18768

merged 11 commits into from
Jan 29, 2024

Conversation

Sinan997
Copy link
Contributor

Resolves #18421

  • if the access_token expires while user is using the application, the token will be regenerated via using refresh_token under the hood. This is already the normal behaviour.

The implementation details

  • save remember_me is checked or not to local_storage.
  • If the users close the browser tab. And when he opened the application again firstly we will check the access_token is it expired or not.
    • If the access_token didn't expire, the user can keep using the application with valid token.
    • If the access_token expired, now we will check remember_me option.
      • If remember_me didn't checked, then we will redirect to login.
      • If remember_me checked, we will regenerate access_token via refresh_token. And user will be able to use application

@Sinan997 Sinan997 added this to the 8.1-preview milestone Jan 16, 2024
@Sinan997 Sinan997 requested a review from masum-ulu January 17, 2024 10:09
@Sinan997 Sinan997 requested a review from masum-ulu January 17, 2024 12:54
@Sinan997 Sinan997 requested a review from masum-ulu January 17, 2024 14:14
@Sinan997 Sinan997 requested a review from masum-ulu January 25, 2024 07:00
@masum-ulu masum-ulu removed the request for review from mahmut-gundogdu January 25, 2024 07:08
@masum-ulu masum-ulu removed the request for review from mahmut-gundogdu January 28, 2024 12:22
@masum-ulu masum-ulu enabled auto-merge January 28, 2024 12:23
@masum-ulu masum-ulu disabled auto-merge January 28, 2024 12:23
@ismcagdas ismcagdas merged commit c5ae142 into dev Jan 29, 2024
2 of 3 checks passed
@ismcagdas ismcagdas deleted the sinan/remember_me branch January 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember Me choice doesn't work properly
4 participants