Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IsRedirectAllowedUrlAsync of IAppUrlProvider async. #18492

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

maliming
Copy link
Member

No description provided.

@maliming maliming modified the milestone: 8.0-final Dec 15, 2023
@maliming maliming changed the base branch from rel-8.0 to dev December 15, 2023 08:06
@maliming maliming added this to the 8.1-preview milestone Dec 15, 2023
@maliming maliming marked this pull request as ready for review December 21, 2023 01:24
@maliming maliming changed the title Support tenant place holder in IsRedirectAllowedUrlAsync method. Make IsRedirectAllowedUrlAsync of IAppUrlProvider async. Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6eb7641) 51.63% compared to head (83e5d42) 51.65%.
Report is 5 commits behind head on dev.

Files Patch % Lines
...o/Abp/AspNetCore/Mvc/UI/RazorPages/AbpPageModel.cs 0.00% 7 Missing ⚠️
...tCore.Mvc/Volo/Abp/AspNetCore/Mvc/AbpController.cs 0.00% 6 Missing ⚠️
...e/Mvc/Authentication/ChallengeAccountController.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18492      +/-   ##
==========================================
+ Coverage   51.63%   51.65%   +0.01%     
==========================================
  Files        3077     3077              
  Lines       97387    97392       +5     
  Branches     7765     7766       +1     
==========================================
+ Hits        50290    50304      +14     
+ Misses      45549    45540       -9     
  Partials     1548     1548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@realLiangshiwei realLiangshiwei merged commit 5d66b03 into dev Jan 3, 2024
4 of 5 checks passed
@realLiangshiwei realLiangshiwei deleted the AppUrlProvider branch January 3, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants