Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Arguments to AbpRabbitMqEventBusOptions #18294

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

realLiangshiwei
Copy link
Member

Description

Resolves #17401

Thanks @htve, After rethinking, I didn't add parameters like QueueAutoDelete, because it may break the work of the event bus system.

Configure<AbpRabbitMqEventBusOptions>(options =>
{
    options.ExchangeArguments["x-delayed-type"] = "direct";
    options.QueueArguments["x-message-ttl"] = 60000;
});
"RabbitMQ": {
  "EventBus": {
    "QueueArguments": {
      "x-message-ttl": 60000
    }
  }
}

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (832609f) 51.62% compared to head (3e73dbf) 51.64%.
Report is 36 commits behind head on dev.

Files Patch % Lines
...bp/Identity/MongoDB/MongoIdentityUserRepository.cs 87.87% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18294      +/-   ##
==========================================
+ Coverage   51.62%   51.64%   +0.01%     
==========================================
  Files        3073     3073              
  Lines       96603    96638      +35     
  Branches     7679     7682       +3     
==========================================
+ Hits        49873    49909      +36     
+ Misses      45202    45200       -2     
- Partials     1528     1529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming merged commit 66ce721 into dev Nov 29, 2023
5 checks passed
@maliming maliming deleted the liangshiwei/rabbitmq branch November 29, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmq event bus support quorum queue
2 participants