Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OnActivated event for ServiceDescriptor. #18259

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Add OnActivated event for ServiceDescriptor. #18259

merged 5 commits into from
Nov 27, 2023

Conversation

maliming
Copy link
Member

@maliming maliming commented Nov 27, 2023

Resolves #18241

We added Repository Implementation Type to DI and set the IsChangeTrackingEnabled in the factory method. Intercepting classes will have performance problems.

Now we will use the OnActivated event to set the IsChangeTrackingEnabled and remove the
Repository Implementation Type from DI.

https://github.com/abpframework/abp/pull/18259/files#diff-14b31eb692e682b42405475f5c13d448b8bc2a7cc532b0b943dda6a5bc77444e

[00:00:22 INF] Starting web host.
[00:00:23 INF] Loaded ABP modules:
[00:00:23 INF] ........
[00:00:24 INF] Initialized all ABP modules.
[00:00:24 INF] Now listening on: https://localhost:44303
[00:00:24 INF] Application started. Press Ctrl+C to shut down.
[00:00:24 INF] Hosting environment: Development

@maliming maliming added this to the 8.0-final milestone Nov 27, 2023
@maliming maliming requested a review from hikalkan November 27, 2023 01:39
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2634198) 51.61% compared to head (3bfdcb2) 51.62%.
Report is 5 commits behind head on rel-8.0.

❗ Current head 3bfdcb2 differs from pull request most recent head 145f2a8. Consider uploading reports for the commit 145f2a8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           rel-8.0   #18259   +/-   ##
========================================
  Coverage    51.61%   51.62%           
========================================
  Files         3070     3073    +3     
  Lines        96571    96600   +29     
  Branches      7676     7679    +3     
========================================
+ Hits         49849    49870   +21     
- Misses       45194    45202    +8     
  Partials      1528     1528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikalkan hikalkan merged commit 966abea into rel-8.0 Nov 27, 2023
3 checks passed
@hikalkan hikalkan deleted the OnActivated branch November 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants