Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LeptonX modules to be added with add-module command #16975

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

yekalkan
Copy link
Member

@yekalkan yekalkan commented Jun 26, 2023

resolves https://github.com/volosoft/volo/issues/14537


@gizemmutukurt
branches: abp: volo/issues/14537, volo: rel-7.2
Test if Lepton X Pro can be replaced with source code on Suite's modules page.

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2023

CLA assistant check
All committers have signed the CLA.

@gizemmutukurt
Copy link
Contributor

Error in build after package is installed.
image

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #16975 (9d5f5de) into rel-7.2 (cdb7392) will decrease coverage by 0.03%.
The diff coverage is 7.54%.

@@             Coverage Diff             @@
##           rel-7.2   #16975      +/-   ##
===========================================
- Coverage    49.44%   49.42%   -0.03%     
===========================================
  Files         3394     3394              
  Lines       105312   105354      +42     
===========================================
- Hits         52072    52070       -2     
- Misses       53240    53284      +44     
Impacted Files Coverage Δ
...Volo.Abp.Cli.Core/Volo/Abp/Cli/AbpCliCoreModule.cs 86.04% <ø> (-0.92%) ⬇️
...Cli.Core/Volo/Abp/Cli/Commands/AddModuleCommand.cs 0.00% <0.00%> (ø)
...olo/Abp/Cli/Commands/ProjectCreationCommandBase.cs 5.83% <0.00%> (ø)
...Abp/Cli/ProjectModification/SolutionModuleAdder.cs 0.00% <0.00%> (ø)
...rojectModification/SolutionPackageVersionFinder.cs 38.66% <21.05%> (-8.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gizemmutukurt gizemmutukurt self-requested a review June 26, 2023 12:29
@gizemmutukurt
Copy link
Contributor

Blazor Server project run error

image

@yekalkan yekalkan merged commit 606d72c into rel-7.2 Jun 26, 2023
@yekalkan yekalkan deleted the volo/issues/14537 branch June 26, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants