dynamicFormTagHelper add Column attribute #16111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yekalkan
requested changes
Apr 11, 2023
| @@ -12,6 +12,9 @@ public class AbpDynamicFormTagHelper : AbpTagHelper<AbpDynamicFormTagHelper, Abp | |||
| [HtmlAttributeName("abp-model")] | |||
| public ModelExpression Model { get; set; } | |||
|
|
|||
| [HtmlAttributeName("abp-column")] | |||
| public int Column { get; set; } | |||
There was a problem hiding this comment.
I think we can use ColumnSize enum here, instead of int.
| @@ -108,6 +108,10 @@ See the [dynamic forms demo page](https://bootstrap-taghelpers.abp.io/Components | |||
|
|
|||
| Sets the c# model for dynamic form. Properties of this modal are turned into inputs in the form. | |||
|
|
|||
| ### abp-column | |||
|
|
|||
| Set up columns in a dynamic form. The value is between 1~6 . | |||
There was a problem hiding this comment.
It would be good if we say this size is used for col-sm.
| @@ -12,6 +12,9 @@ public class AbpDynamicFormTagHelper : AbpTagHelper<AbpDynamicFormTagHelper, Abp | |||
| [HtmlAttributeName("abp-model")] | |||
| public ModelExpression Model { get; set; } | |||
|
|
|||
| [HtmlAttributeName("abp-column")] | |||
There was a problem hiding this comment.
column-size would be a better name for the attribute.
yekalkan
requested changes
Apr 11, 2023
| { | ||
| return htmlContent; | ||
| } | ||
|
|
||
| var col_class = $"col-12 col-sm-" + (12 / TagHelper.Column); | ||
| var col_class = $"col-12 col-sm-" + TagHelper.ColumnSize; |
There was a problem hiding this comment.
i tink it should be ((int) TagHelper.ColumnSize)
yekalkan
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add new attribute
ColumntodynamicFormTagHelperbefore:
after:
Checklist
How to test it?
add
abp-columntoabp-dynamic-formtag<abp-dynamic-form abp-model="@Model.MyDetailedModel" abp-column="2"/>