Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix !important on vc.scss to solve issue on client side #15921

Closed
wants to merge 1 commit into from
Closed

Fix !important on vc.scss to solve issue on client side #15921

wants to merge 1 commit into from

Conversation

andmattia
Copy link
Contributor

Description

Resolves a UI issue on doc module directly imported on a APB project.

@andmattia andmattia closed this by deleting the head repository Mar 9, 2023
@andmattia
Copy link
Contributor Author

How can you solve this issue without !important tag on CSS?

@andmattia andmattia reopened this Mar 10, 2023
@berkansasmaz
Copy link
Member

Before we can properly review PR, we need to better understand what it solves. Is there an open issue related to the problem?

@andmattia
Copy link
Contributor Author

No.

It's quite simple to reproduce in 7.0.2.

  1. Create empty project
  2. Add Docs Module
  3. Run

If you look in the right corner where project version is show you can see this issue
image

this is the css
image

If you put !important in padding and backgroud props this gone away

image
image

I think this is caused by LeptonXPro in select2.scss

input-group {
  .input-group-text {
    padding: 0.4rem 0.9rem !important;
    font-size: 0.875rem;
    color: var(--lpx-content-text) !important;
    background-color:  var(--lpx-card-bg)  !important; 
    border-radius: 0.475rem;
  }
...

I check your docs site but it use base and not LeptonXPro

@berkansasmaz
Copy link
Member

Thank you for explaining the issue 🙏 Your PR will be reviewed as soon as possible 🥳

@armgnunlu armgnunlu modified the milestones: 7.2-preview, 7.3-preview Apr 10, 2023
@armgnunlu armgnunlu modified the milestones: 7.3-preview, 7.2-final Apr 11, 2023
@berkansasmaz
Copy link
Member

Hi @andmattia, we could not merge the PR due to conflict. We can't sync with dev because we don't have update permission. Can you update your branch?

@armgnunlu armgnunlu modified the milestones: 7.2-final, 7.3-preview Apr 11, 2023
@ebicoglu
Copy link
Member

@andmattia fix the conflict please

@andmattia
Copy link
Contributor Author

@berkansasmaz @ebicoglu I've update my branch

@berkansasmaz
Copy link
Member

@andmattia Unfortunately, the problem seems unresolved. We still can't merge PR. It seems that the problem is not with you, but as a result we are not able to merge the PR. Please fix the problem or create a new PR.

@berkansasmaz
Copy link
Member

Hi @andmattia, sorry I had to recreate the PR. That's why I'm closing this PR.

Thank you so much for contributing 🥳🥳.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants