Issue/10019 move oauth seperated package #15201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braim23
approved these changes
Dec 26, 2022
|
|
||
| return headers; | ||
| intercept(req: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> { | ||
| return next.handle(req); |
There was a problem hiding this comment.
we should keep this.httpWaitService.addRequest(request); and .pipe(finalize(() => this.httpWaitService.deleteRequest(request)));
| @@ -0,0 +1 @@ | |||
| export * from './ auth-flow-strategy'; | |||
There was a problem hiding this comment.
it should be './auth-flow-strategy'
| @@ -11,6 +11,7 @@ | |||
| "@ngx-validate/core", | |||
| "@swimlane/ngx-datatable", | |||
| "bootstrap", | |||
| "@popperjs/core" | |||
| "@popperjs/core", | |||
| "@abp/ng.oauth" | |||
There was a problem hiding this comment.
i think theme shared package doesn't depended oauth package
mahmut-gundogdu
force-pushed
the
issue/10019-move-oauth-seperated-package
branch
from
02b9f99 to
3a3a823
Compare
muhammedaltug
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication codes move to OAuth package.
Resolves #10019
Test steps.
Run run build-all
Run copy-to-test
test on templates.
There is no new feature. This is only a refactoring about authentication. All auth related features will be work as well.