Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Change-Theme schematic #14445

Merged
merged 6 commits into from
Oct 27, 2022
Merged

Add Change-Theme schematic #14445

merged 6 commits into from
Oct 27, 2022

Conversation

mahmut-gundogdu
Copy link
Contributor

@mahmut-gundogdu mahmut-gundogdu commented Oct 26, 2022 •
edited
Loading

@mahmut-gundogdu mahmut-gundogdu added this to the 6.0-patch milestone Oct 26, 2022
@mahmut-gundogdu mahmut-gundogdu changed the base branch from dev to rel-6.0 October 26, 2022 07:08
@EngincanV EngincanV mentioned this pull request Oct 26, 2022
Closed
muhammedaltug
muhammedaltug reviewed Oct 26, 2022
View reviewed changes
npm/ng-packs/packages/schematics/src/commands/change-theme/schema.json Outdated Show resolved Hide resolved
npm/ng-packs/packages/schematics/src/commands/change-theme/schema.json Outdated Show resolved Hide resolved
npm/ng-packs/packages/schematics/src/commands/change-theme/schema.json Outdated Show resolved Hide resolved
npm/ng-packs/packages/schematics/src/commands/change-theme/style-map.ts
bundleName: 'abp-bundle.rtl',
},
]);
// the code written by Github co-pilot. thank go-pilot. You are the best sidekick.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should co-pilot instead of go-pilot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch but no, brand is co-pilot
image

@muhammedaltug muhammedaltug merged commit 8298449 into rel-6.0 Oct 27, 2022
@muhammedaltug muhammedaltug deleted the issue/12213 branch October 27, 2022 05:33
@EngincanV EngincanV mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EngincanV EngincanV EngincanV left review comments

@fatihskilic fatihskilic fatihskilic approved these changes

@muhammedaltug muhammedaltug muhammedaltug approved these changes

Assignees
No one assigned
Labels
ui-angular
Projects
None yet
Milestone
6.0-patch
Development

Successfully merging this pull request may close these issues.
4 participants
@mahmut-gundogdu @muhammedaltug @fatihskilic @EngincanV