Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get application name's default value from the entrance assembly #14403

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Get application name's default value from the entrance assembly #14403

merged 3 commits into from
Oct 21, 2022

Conversation

hikalkan
Copy link
Member

With this PR, default value of the application name (that can be retrieved with IApplicationNameAccessor.ApplicationName) is calculated as:

  • Try to get from AbpApplicationCreationOptions.ApplicationName.
  • If not provided, try to get from IConfiguration["ApplicationName"].
  • If not provided, try to get from Assembly.GetEntryAssembly().GetName().Name
  • If not found, use null.

@hikalkan hikalkan added this to the 7.0-preview milestone Oct 20, 2022
@hikalkan hikalkan requested a review from maliming October 20, 2022 14:34
@maliming maliming merged commit 7106bc3 into dev Oct 21, 2022
@maliming maliming deleted the appname-default branch October 21, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliming maliming maliming approved these changes

Assignees
No one assigned
Labels
abp-framework enhancement
Projects
None yet
Milestone
7.0-preview
Development

Successfully merging this pull request may close these issues.
2 participants
@hikalkan @maliming