Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Openiddict migration guide need some additional steps #14010

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

gterdem
Copy link
Contributor

@gterdem gterdem commented Sep 13, 2022

Closes https://github.com/volosoft/volo/issues/11869

@mahmut-gundogdu

2- 'OpenIddictDataSeedConibutor' has some string fields that should change depending on the app name. (the user does not realise MyAppName should change)

- Create a folder named *OpenIddict* under the Domain project and copy the [OpenIddictDataSeedContributor.cs](https://github.com/abpframework/abp-samples/blob/master/Ids2OpenId/src/Ids2OpenId.Domain/OpenIddict/OpenIddictDataSeedContributor.cs) under this folder. Rename all the `Ids2OpenId` with your project name.

We have an explanation about renaming. Maybe I couldn't understand this, can you explain more?

@gterdem gterdem added this to the 6.0-final milestone Sep 13, 2022
@@ -73,7 +78,7 @@ Use the `abp update` command to update your existing application. See [Upgrading

#### OpenIddictDataSeedContributor

- Create a folder named *OpenIddict* under the Domain project and copy the [OpenIddictDataSeedContributor.cs](https://github.com/abpframework/abp-samples/blob/master/Ids2OpenId/src/Ids2OpenId.Domain/OpenIddict/OpenIddictDataSeedContributor.cs) under this folder. Rename all the `Ids2OpenId` with your project name.
- Create a folder named *OpenIddict* under the Domain project and copy the [OpenIddictDataSeedContributor.cs](https://github.com/abpframework/abp-samples/blob/master/Ids2OpenId/src/Ids2OpenId.Domain/OpenIddict/OpenIddictDataSeedContributor.cs) under this folder. **Rename** all the `Ids2OpenId` with your project name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is totally fine.

@gterdem gterdem marked this pull request as ready for review September 14, 2022 06:33
@gterdem gterdem merged commit c066ea6 into rel-6.0 Sep 14, 2022
@gterdem gterdem deleted the gterdem/migration-guide-update branch September 14, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants