Cms-kit tag issues 13417 #13718
Merged
Cms-kit tag issues 13417 #13718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rqx110
reviewed
Aug 17, 2022
...ms-kit/src/Volo.CmsKit.Admin.Application.Contracts/Volo/CmsKit/Admin/Tags/EntityTagSetDto.cs
Outdated
Show resolved
Hide resolved
rqx110
reviewed
Aug 17, 2022
| "MaxTagLengthExceptionMessage", | ||
| nameof(tag), | ||
| TagConsts.MaxNameLength, | ||
| typeof(EntityTagSetDto).FullName |
There was a problem hiding this comment.
really need this full name in Validation message?
There was a problem hiding this comment.
I think it seems better to find the error easily.
There was a problem hiding this comment.
I don't think the end-user need this detail info.
…lo/CmsKit/Admin/Tags/EntityTagSetDto.cs Co-authored-by: Qingxiao Ren <[email protected]>
rqx110
reviewed
Aug 17, 2022
modules/cms-kit/src/Volo.CmsKit.Domain.Shared/Volo/CmsKit/Localization/Resources/en.json
Outdated
Show resolved
Hide resolved
enisn
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13417