Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapr integration #13573

Merged
merged 23 commits into from
Aug 23, 2022
Merged

Dapr integration #13573

merged 23 commits into from
Aug 23, 2022

Conversation

maliming
Copy link
Member

@maliming maliming commented Aug 5, 2022 •
edited
Loading

Resolve #13337
Resolve #13338
Resolve #13339
Resolve #13341
Resolve #13582
Resolve #13342

abpframework/abp-samples#193

hikalkan and others added 20 commits July 19, 2022 13:22
@hikalkan
Added empty Volo.Abp.Dapr package
d284bb0
@hikalkan
Added Volo.Abp.EventBus.Dapr package.
6f9750f
@hikalkan
Added Volo.Abp.Http.Client.Dapr package.
e8ab404
@hikalkan
Created empty Volo.Abp.AspNetCore.Dapr package.
f1871b8
@hikalkan
Set rootnamespaces to empty for the new dapr integration packages.
4be7bc3
@maliming
Merge branch 'dev' into dapr-integration
07af3ef
@maliming
Add AbpDaprOptions.
b9b7fbf
@maliming
Merge branch 'dev' into dapr-integration
d52c0de
@maliming
Add AbpDaprClientFactory.
d6455db
@maliming
Use abp JsonSerializerOptions in AbpDaprClientFactory.
000f32e
@maliming
Update AbpDaprModule.cs
24a13f4
@maliming
Update Volo.Abp.Dapr.csproj
54e9c67
@maliming
Implement the Dapr event bus.
4a72449
@realLiangshiwei
Implement the Dapr http client
bccd115
@realLiangshiwei
Add AbpInvocationHandler
c559fa4
@maliming
Merge branch 'dev' into dapr-integration
d8bf750
@maliming
Add framework/src/Volo.Abp.AspNetCore.Dapr.EventBus package.
4d6987a
@realLiangshiwei
Implement the Dapr DistributedLock
b7d5ad7
@realLiangshiwei
Add DefaultTimeout
ecd834c
@realLiangshiwei
Update AbpDistributedLockDaprOptions
47431aa
@maliming maliming marked this pull request as ready for review August 12, 2022 03:02
@maliming maliming added this to the 7.0-preview milestone Aug 12, 2022
@maliming maliming requested a review from hikalkan August 20, 2022 06:55
hikalkan
hikalkan requested changes Aug 22, 2022
View reviewed changes
.../Volo.Abp.DistributedLocking.Dapr/Volo/Abp/DistributedLocking/Dapr/DaprAbpDistributedLock.cs
timeout = DistributedLockDaprOptions.DefaultTimeout;
}

var daprClient = await DaprClientFactory.CreateAsync();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DaprClient disposable? Shouldn't we dispose the client after lock is released (or if can't be obtained)? Also check other places we used the DaprClient. Also, is DaprClient thread-safe and reusable (I don't know now)?

Copy link
Member

@realLiangshiwei realLiangshiwei Aug 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dapr/dotnet-sdk/blob/016545ac0d5c114b72795e187069d21f0a333048/src/Dapr.Client/TryLockResponse.cs#L54

DaprClient is thread-safe and reusable, This is also used by the Dapr sdk

@hikalkan
Copy link
Member

Thanks for the great implementation. I will organize its documentation.

One more comment, in addition to the comments I've done:

If Volo.Abp.AspNetCore.Dapr depends on Volo.Abp.AspNetCore.Mvc, its name can be Volo.Abp.AspNetCore.Mvc.Dapr, right? Or can it depend on Volo.Abp.AspNetCore instead of Volo.Abp.AspNetCore.Mvc?

@hikalkan hikalkan mentioned this pull request Aug 22, 2022
Closed
@maliming
Copy link
Member Author

Thanks for the great implementation. I will organize its documentation.

One more comment, in addition to the comments I've done:

If Volo.Abp.AspNetCore.Dapr depends on Volo.Abp.AspNetCore.Mvc, its name can be Volo.Abp.AspNetCore.Mvc.Dapr, right? Or can it depend on Volo.Abp.AspNetCore instead of Volo.Abp.AspNetCore.Mvc?

renamed to Volo.Abp.AspNetCore.Mvc.Dapr and Volo.Abp.AspNetCore.Mvc.Dapr.EventBus

@hikalkan hikalkan merged commit 4604e16 into dev Aug 23, 2022
@hikalkan hikalkan deleted the dapr-integration branch August 23, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realLiangshiwei realLiangshiwei realLiangshiwei left review comments

@hikalkan hikalkan hikalkan approved these changes

Assignees
No one assigned
Labels
abp-framework feature
Projects
None yet
Milestone
7.0-preview
3 participants
@maliming @hikalkan @realLiangshiwei