Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: Make Cli compatible with LeptonX packages #13520

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

yekalkan
Copy link
Member

@yekalkan yekalkan commented Aug 2, 2022

  • Ignore LeptonX packages when detecting solution's ABP version.
  • Don't use ABP framework version when updating LeptonX packages

resolves #13495

@realLiangshiwei
Copy link
Member

@yekalkan The unit tests failed.

@yekalkan
Copy link
Member Author

yekalkan commented Aug 2, 2022

@yekalkan The unit tests failed.

Fixed.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #13520 (b95157e) into rel-6.0 (7e3e0a2) will decrease coverage by 0.33%.
The diff coverage is 57.37%.

@@             Coverage Diff             @@
##           rel-6.0   #13520      +/-   ##
===========================================
- Coverage    50.47%   50.13%   -0.34%     
===========================================
  Files         3212     3248      +36     
  Lines        96410    97411    +1001     
===========================================
+ Hits         48660    48837     +177     
- Misses       47750    48574     +824     
Impacted Files Coverage Δ
...etCore/Mvc/ExceptionHandling/AbpExceptionFilter.cs 91.83% <ø> (ø)
...re/Mvc/ExceptionHandling/AbpExceptionPageFilter.cs 92.98% <ø> (ø)
...ectModification/VoloNugetPackagesVersionUpdater.cs 0.00% <0.00%> (ø)
...iLingualObjects/MultiLingualObjectManager_Tests.cs 0.00% <0.00%> (ø)
...rojectModification/SolutionPackageVersionFinder.cs 46.66% <64.70%> (+24.68%) ⬆️
...p/MultiLingualObjects/MultiLingualObjectManager.cs 71.73% <75.00%> (+1.97%) ⬆️
...nyName.MyProjectName.Web/MyProjectNameWebModule.cs 77.71% <93.33%> (+2.05%) ⬆️
...workCore/Volo/CmsKit/Pages/EfCorePageRepository.cs 100.00% <100.00%> (ø)
...B/Volo/CmsKit/MongoDB/Pages/MongoPageRepository.cs 100.00% <100.00%> (ø)
...Iddict/Controllers/TokenController.RefreshToken.cs 0.00% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@realLiangshiwei realLiangshiwei merged commit 1e921b2 into rel-6.0 Aug 2, 2022
@realLiangshiwei realLiangshiwei deleted the issues/13495 branch August 2, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants