Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'Light Mode' for ABP CLI #12779

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Support 'Light Mode' for ABP CLI #12779

merged 2 commits into from
Sep 29, 2022

Conversation

roc916
Copy link
Contributor

@roc916 roc916 commented May 27, 2022 •
edited
Loading

Resolves: #12256

Related with serilog/serilog-sinks-console#123

  • need more test eg. macOS
  • waiting for the next release of Serilog.Sinks.Console

Before:
dark-1
light-1

After:
dark-2
light-2

@roc916 roc916 marked this pull request as draft May 27, 2022 03:40
@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added inactive and removed inactive labels Sep 8, 2022
@roc916 roc916 marked this pull request as ready for review September 9, 2022 02:50
@roc916
Copy link
Contributor Author

roc916 commented Sep 9, 2022

@maliming Would you mind helping me with this problem?

@maliming
Copy link
Member

maliming commented Sep 9, 2022

hi

Is dotnet cli has similar feature? or other cli tools?

@roc916
Copy link
Contributor Author

roc916 commented Sep 9, 2022

Is dotnet cli has similar feature? or other cli tools?

dotnet cli doesn't have this problem.

dotnet cli:
image

but ABP CLI Program.cs#L29 used Serilog.Sinks.Console and default theme (SystemConsoleTheme.Literate) .

abp cli and macOS Basic:
image

See: serilog/serilog-sinks-console#123

@roc916
Copy link
Contributor Author

roc916 commented Sep 9, 2022

SystemConsoleTheme.Literate(default theme):
image

AnsiConsoleTheme.Sixteen:
image

@maliming maliming self-requested a review September 15, 2022 00:31
@maliming maliming added this to the 7.0-preview milestone Sep 15, 2022
@realLiangshiwei realLiangshiwei merged commit 5fbb64f into abpframework:dev Sep 29, 2022
@roc916 roc916 deleted the abp-cli-light-mode branch September 29, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realLiangshiwei realLiangshiwei realLiangshiwei approved these changes

@maliming maliming Awaiting requested review from maliming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0-preview
Development

Successfully merging this pull request may close these issues.

Please support 'Light Mode' for ABP CLI in terminal
3 participants
@roc916 @maliming @realLiangshiwei