Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with API Versioning. #11551

Merged
merged 15 commits into from
Feb 15, 2022
Merged

Compatible with API Versioning. #11551

merged 15 commits into from
Feb 15, 2022

Conversation

maliming
Copy link
Member

@maliming maliming commented Feb 10, 2022

@maliming maliming added this to the 5.2-preview milestone Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #11551 (8d0ac6b) into dev (20bde1b) will increase coverage by 49.42%.
The diff coverage is 50.00%.

❗ Current head 8d0ac6b differs from pull request most recent head 4b4f73a. Consider uploading reports for the commit 4b4f73a to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           dev   #11551       +/-   ##
========================================
+ Coverage     0   49.42%   +49.42%     
========================================
  Files        0     3091     +3091     
  Lines        0    91846    +91846     
========================================
+ Hits         0    45397    +45397     
- Misses       0    46449    +46449     
Impacted Files Coverage Δ
...ng/Generators/JQuery/JQueryProxyScriptGenerator.cs 82.46% <0.00%> (ø)
...ttp/Client/ClientProxying/CurrentApiVersionInfo.cs 20.00% <20.00%> (ø)
.../Abp/Http/Client/ClientProxying/ClientProxyBase.cs 77.61% <33.33%> (ø)
...tCore/Mvc/AspNetCoreApiDescriptionModelProvider.cs 94.27% <66.66%> (ø)
...Volo/Abp/AspNetCore/Mvc/AbpAspNetCoreMvcOptions.cs 100.00% <100.00%> (ø)
...AspNetCore/Mvc/Conventions/AbpServiceConvention.cs 91.60% <100.00%> (ø)
...e/Mvc/Versioning/HttpContextRequestedApiVersion.cs 100.00% <100.00%> (ø)
...olo/Abp/Http/Modeling/ModuleApiDescriptionModel.cs 51.42% <100.00%> (ø)
...Mvc/ApplicationConfigurations/CurrentCultureDto.cs 100.00% <0.00%> (ø)
...ication.Contracts/Volo/Docs/Projects/ProjectDto.cs 100.00% <0.00%> (ø)
... and 3088 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bde1b...4b4f73a. Read the comment docs.

@maliming maliming marked this pull request as ready for review February 11, 2022 06:45
@hikalkan hikalkan merged commit 497fdd7 into dev Feb 15, 2022
@hikalkan hikalkan deleted the Api-Versioning branch February 15, 2022 04:56
@hikalkan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Versioning test, finalize & document
3 participants