Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Blazor module extensibility feature #11086

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Conversation

realLiangshiwei
Copy link
Member

@realLiangshiwei realLiangshiwei commented Dec 28, 2021

Resolve #11060

image

image

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #11086 (ff72232) into dev (b3dfef9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #11086      +/-   ##
==========================================
- Coverage   54.45%   54.44%   -0.02%     
==========================================
  Files        2658     2659       +1     
  Lines       76418    76475      +57     
==========================================
+ Hits        41617    41637      +20     
- Misses      34801    34838      +37     
Impacted Files Coverage Δ
...jection/ServiceCollectionPreConfigureExtensions.cs 85.00% <0.00%> (-15.00%) ⬇️
...work/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/CliUrls.cs 0.00% <0.00%> (ø)
...k/src/Volo.Abp.Json/Volo/Abp/Json/AbpJsonModule.cs 100.00% <0.00%> (ø)
...bp.Core/Volo/Abp/Options/PreConfigureActionList.cs 100.00% <0.00%> (ø)
.../Abp/Cli/ProjectModification/NpmPackagesUpdater.cs 0.00% <0.00%> (ø)
...ding/Building/ModuleProjectBuildPipelineBuilder.cs 0.00% <0.00%> (ø)
...ng/Building/Steps/MakeProxyJsonFileEmbeddedStep.cs 0.00% <0.00%> (ø)
...p/EventBus/Distributed/LocalDistributedEventBus.cs 62.38% <0.00%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6b2ff...ff72232. Read the comment docs.

@realLiangshiwei realLiangshiwei marked this pull request as draft December 28, 2021 02:20
@realLiangshiwei realLiangshiwei marked this pull request as ready for review December 28, 2021 04:00
@berkansasmaz
Copy link
Member

I could not test it in Blazor-Wasm due to an error like the picture below. Probably not related to PR, just wanted to point out.

Screen Shot 2021-12-29 at 14 26 49

However, I was able to test it on Blazor-Server.

Conclusion:

I can add a new record, but then when I try to add a new record again, the connection is broken.

Kapture 2021-12-29 at 15 27 43

Screen Shot 2021-12-29 at 15 30 34

Logs

[15:30:15 WRN] Unhandled exception rendering component: Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
   at Volo.Abp.BlazoriseUI.Components.ObjectExtending.LookupExtensionProperty`2.<>c.<BuildRenderTree>b__17_2(SelectItem`1 item) in /Users/berkan/Documents/workspace/abp/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/LookupExtensionProperty.razor:line 12
   at Blazorise.Components.Autocomplete`2.GetDisplayText(TItem item)
   at Blazorise.Components.Autocomplete`2.<>c__DisplayClass7_0.<<SetParametersAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Blazorise.BaseAfterRenderComponent.OnAfterRenderAsync(Boolean firstRender)
[15:30:15 ERR] Unhandled exception in circuit 'tt7qjT9psYBSiIeN_TaiVsVMlktCMFD2E6n91XYz3CU'.
System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.)
 ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Volo.Abp.BlazoriseUI.Components.ObjectExtending.LookupExtensionProperty`2.<>c.<BuildRenderTree>b__17_2(SelectItem`1 item) in /Users/berkan/Documents/workspace/abp/framework/src/Volo.Abp.BlazoriseUI/Components/ObjectExtending/LookupExtensionProperty.razor:line 12
   at Blazorise.Components.Autocomplete`2.GetDisplayText(TItem item)
   at Blazorise.Components.Autocomplete`2.<>c__DisplayClass7_0.<<SetParametersAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Blazorise.BaseAfterRenderComponent.OnAfterRenderAsync(Boolean firstRender)
   --- End of inner exception stack trace ---

@berkansasmaz berkansasmaz merged commit b84253f into dev Jan 5, 2022
@berkansasmaz berkansasmaz deleted the liangshiwei/blazor branch January 5, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Blazor module extensibility feature
2 participants