Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityServer Module translations #11068

Merged
merged 5 commits into from
Dec 27, 2021
Merged

Conversation

afresh
Copy link
Contributor

@afresh afresh commented Dec 24, 2021

No description provided.

Copy link
Contributor Author

@afresh afresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed.

@berkansasmaz
Copy link
Member

Thanks for your contribution ✌️

@realLiangshiwei realLiangshiwei added this to the 5.1-preview milestone Dec 27, 2021
@realLiangshiwei realLiangshiwei merged commit 15db5af into abpframework:dev Dec 27, 2021
@afresh
Copy link
Contributor Author

afresh commented Dec 27, 2021

@realLiangshiwei Hello, I have a question about this pr. I find that you have changed the Chinese punctuation into English punctuation. What is the reason for this?

@realLiangshiwei
Copy link
Member

Hi @afresh , because we always use English punctuation in documents, in order to keep the style uniform, so I made changes,

@afresh
Copy link
Contributor Author

afresh commented Dec 27, 2021

@realLiangshiwei Thank you. I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants