-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new hosting model for the app template. #10928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hikalkan
reviewed
Dec 23, 2021
...work/src/Volo.Abp.AspNetCore/Microsoft/AspNetCore/Builder/AbpApplicationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.Core/Volo/Abp/AbpApplicationCreationOptions.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
…vices to SkipConfigureServices.
hikalkan
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #6828
Resolve #10426
Changes:
The
PreConfigureServices
,ConfigureServices
,PostConfigureServices
,OnPreApplicationInitialization
,OnApplicationInitialization
,OnPostApplicationInitialization
methods of module have theAsync
version now. If you need to use an async method, please override the corresponding method. Async methods automatically call sync methods by default.https://github.com/abpframework/abp/blob/new-hosting-model/framework/src/Volo.Abp.Core/Volo/Abp/Modularity/AbpModule.cs#L34-L109
Add the new
AbpAsyncIntegratedTest
andAbpAspNetCoreAsyncTestBase
.The test class needs to implement the
IAsyncLifetime
interface, which has been implemented byAbpAspNetCoreAsyncTestBase
.Demo test classes:
https://github.com/abpframework/abp/blob/new-hosting-model/framework/test/Volo.Abp.AspNetCore.Mvc.Tests/Volo/Abp/AspNetCore/Mvc/AbpAspNetCoreAsyncTestBase_Tests.cs
https://github.com/abpframework/abp/blob/new-hosting-model/framework/test/Volo.Abp.Core.Tests/Volo/Abp/DynamicProxy/AbpInterceptionTestBase.cs
Breaking changes:
If you use async methods in your module, please keep the same sync methods for compatibility.
eg: https://github.com/abpframework/abp/blob/new-hosting-model/modules/identityserver/src/Volo.Abp.IdentityServer.Domain/Volo/Abp/IdentityServer/AbpIdentityServerDomainModule.cs#L137-L163
Or