Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10920 - Define constants for missing cli command names #10921

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

iyilm4z
Copy link
Contributor

@iyilm4z iyilm4z commented Dec 13, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #10921 (199e40d) into dev (5bea437) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #10921      +/-   ##
==========================================
- Coverage   54.53%   54.52%   -0.02%     
==========================================
  Files        2650     2650              
  Lines       75740    75770      +30     
==========================================
+ Hits        41307    41310       +3     
- Misses      34433    34460      +27     
Impacted Files Coverage Δ
...Cli.Core/Volo/Abp/Cli/Commands/AddModuleCommand.cs 0.00% <ø> (ø)
...li.Core/Volo/Abp/Cli/Commands/AddPackageCommand.cs 0.00% <ø> (ø)
...Abp.Cli.Core/Volo/Abp/Cli/Commands/BuildCommand.cs 0.00% <ø> (ø)
...bp.Cli.Core/Volo/Abp/Cli/Commands/BundleCommand.cs 0.00% <ø> (ø)
...i/Commands/CreateMigrationAndRunMigratorCommand.cs 0.00% <ø> (ø)
...Cli.Core/Volo/Abp/Cli/Commands/GetSourceCommand.cs 0.00% <ø> (ø)
....Abp.Cli.Core/Volo/Abp/Cli/Commands/HelpCommand.cs 0.00% <ø> (ø)
...i.Core/Volo/Abp/Cli/Commands/InstallLibsCommand.cs 0.00% <ø> (ø)
...i.Core/Volo/Abp/Cli/Commands/ListModulesCommand.cs 0.00% <ø> (ø)
...Abp.Cli.Core/Volo/Abp/Cli/Commands/LoginCommand.cs 0.00% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ac3b3...199e40d. Read the comment docs.

@yekalkan yekalkan self-requested a review December 13, 2021 09:02
@yekalkan yekalkan added this to the 5.1-preview milestone Dec 13, 2021
@iyilm4z
Copy link
Contributor Author

iyilm4z commented Dec 15, 2021

Hi @maliming, apparently the codecov/project check is failed and i'm not familiar with it. Is there anything you guys wait from me to do?

@maliming
Copy link
Member

codecov is for reference only, you can ignore it.

@iyilm4z
Copy link
Contributor Author

iyilm4z commented Dec 19, 2021

Guys sorry for the noise about the last two commits. I was working on another issue and i just did a mistake.

@berkansasmaz berkansasmaz linked an issue Dec 20, 2021 that may be closed by this pull request
@iyilm4z iyilm4z mentioned this pull request Dec 21, 2021
@maliming maliming merged commit 98c4291 into abpframework:dev Dec 22, 2021
@iyilm4z iyilm4z deleted the cli-refactoring branch December 22, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define constants for missing cli command names
3 participants