Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown in CMS-Kit comments #10792

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Support markdown in CMS-Kit comments #10792

merged 4 commits into from
Dec 6, 2021

Conversation

yekalkan
Copy link
Member

resolves #10789

@berkansasmaz Can you check if it looks fine on community.abp.io?

image

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (dev@965f10e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #10792   +/-   ##
======================================
  Coverage       ?   54.57%           
======================================
  Files          ?     2652           
  Lines          ?    75791           
  Branches       ?        0           
======================================
  Hits           ?    41362           
  Misses         ?    34429           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965f10e...e618ec1. Read the comment docs.

@berkansasmaz
Copy link
Member

berkansasmaz commented Dec 1, 2021

There is a security vulnerability.

For example:

Kapture 2021-12-01 at 09 59 18

@berkansasmaz
Copy link
Member

I could not find any problem visually on community.abp.io.

Screen Shot 2021-12-01 at 09 52 43

@yekalkan
Copy link
Member Author

yekalkan commented Dec 1, 2021

There is a security vulnerability.

Now it is prevented.

@berkansasmaz
Copy link
Member

berkansasmaz commented Dec 1, 2021

LGTM 😊

@hikalkan hikalkan requested a review from enisn December 3, 2021 07:12
@hikalkan hikalkan merged commit f609f5d into dev Dec 6, 2021
@hikalkan hikalkan deleted the issue/10789 branch December 6, 2021 08:48
@hikalkan
Copy link
Member

hikalkan commented Dec 6, 2021

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support markdown in CMS-Kit comments
4 participants