Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IValueValidatorFactory #10732

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Add IValueValidatorFactory #10732

merged 6 commits into from
Jan 10, 2022

Conversation

maliming
Copy link
Member

Resolve #10724

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #10732 (aa7776f) into dev (11b5aec) will increase coverage by 4.93%.
The diff coverage is 95.74%.

❗ Current head aa7776f differs from pull request most recent head 3b12c26. Consider uploading reports for the commit 3b12c26 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #10732      +/-   ##
==========================================
+ Coverage   49.51%   54.44%   +4.93%     
==========================================
  Files        3080     2660     -420     
  Lines       91303    76448   -14855     
==========================================
- Hits        45205    41622    -3583     
+ Misses      46098    34826   -11272     
Impacted Files Coverage Δ
...nverters/NewtonsoftStringValueTypeJsonConverter.cs 85.71% <85.71%> (+1.78%) ⬆️
...ment/JsonConverters/ValueValidatorJsonConverter.cs 83.33% <85.71%> (+2.77%) ⬆️
.../AbpFeatureManagementApplicationContractsModule.cs 89.47% <100.00%> (-10.53%) ⬇️
...AbpFeatureManagementApplicationContractsOptions.cs 100.00% <100.00%> (ø)
...ent/JsonConverters/StringValueTypeJsonConverter.cs 92.00% <100.00%> (+2.00%) ⬆️
...Management/JsonConverters/ValueValidatorFactory.cs 100.00% <100.00%> (ø)
...Shared/AbpApplicationBuilderErrorPageExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...zorPages/ServiceBasedPageModelActivatorProvider.cs 0.00% <0.00%> (-100.00%) ⬇️
...eManagement/FeaturePermissionDefinitionProvider.cs 0.00% <0.00%> (-100.00%) ⬇️
...t/FeatureManagementApplicationAutoMapperProfile.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 491 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aa065...3b12c26. Read the comment docs.

@maliming maliming requested a review from hikalkan January 10, 2022 01:32
@realLiangshiwei realLiangshiwei self-requested a review January 10, 2022 09:38
@hikalkan hikalkan merged commit bc00752 into dev Jan 10, 2022
@hikalkan hikalkan deleted the maliming/IValueValidatorFactory branch January 10, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to have custom validation on features
3 participants