Localize Make the PermissionAppService.GetAsync method slow

[Nokecy]

abp/modules/permission-management/src/Volo.Abp.PermissionManagement.Application/Volo/Abp/PermissionManagement/PermissionAppService.cs

Line 73 in 810949f

DisplayName = permission.DisplayName.Localize(StringLocalizerFactory),

1500 permission items：
remove Localize before--10s+
remove Localize after 300ms+

[Nokecy]

abp/modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs

Line 34 in 810949f

await PermissionGrantRepository.FindAsync(name, providerName, providerKey) != null,

abp/modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs

Line 46 in 810949f

var permissionGrant = await PermissionGrantRepository.FindAsync(name, Name, roleName);

Maybe PermissionStore.IsGrantedAsync should be used

[maliming]

Thanks for the feedback, I will check.

[maliming]

hi @Nokecy I didn't find any performance issues. We used caching. Can you share a project?

[Nokecy]

I did some more tests, when too many localized resources do not exist, the speed is too slow。

[Nokecy]

In addition, replacing Permission Grant Repository with PermissionStore can improve 2-3s @maliming

[maliming]

too many localized resources do not exist, the speed is too slow。

I'll test, but why is there a not exist situation? What is your use case?

replacing Permission Grant Repository with PermissionStore can improve 2-3s

The PermissionStore is using cache but PermissionGrantRepository is not.

[Nokecy]

I will change my project and add missing items

abp/modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs

Line 34 in 810949f

await PermissionGrantRepository.FindAsync(name, providerName, providerKey) != null,

abp/modules/identity/src/Volo.Abp.PermissionManagement.Domain.Identity/Volo/Abp/PermissionManagement/Identity/RolePermissionManagementProvider.cs

Line 46 in 810949f

var permissionGrant = await PermissionGrantRepository.FindAsync(name, Name, roleName);

Maybe PermissionStore.IsGrantedAsync should be used

Does it need to be changed here? I can PR

[maliming]

I did the PR.#6480

[hikalkan]

Actually, PermissionManagementProvider is only used when you manage permission (change permission of a user/role on UI) and it may be a bit slow. It bypasses cache to be able to work with the actual data source. However, using cache for reads seems no problem. I will accept the PR.