Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Management Modal improvements (MVC UI) #5327

Closed
hikalkan opened this issue Sep 7, 2020 · 3 comments · Fixed by #5361
Closed

Feature Management Modal improvements (MVC UI) #5327

hikalkan opened this issue Sep 7, 2020 · 3 comments · Fixed by #5361

Comments

@hikalkan
Copy link
Member

hikalkan commented Sep 7, 2020

image

  • Checkboxes should be on the left side of the feature name
  • Child features should be only selectable when the parent was selected (recursively), just like the permissions.
  • Numeric features should properly validate numbers (also in the server) and should show a numeric textbox.
  • Test if validators are properly working and fix if not.

These are valid for the SaaS module too.

I am currently writing the Features document: https://github.com/abpframework/abp/blob/rel-3.1/docs/en/Features.md
You can read the document when I complete (tomorrow) and work on this issue then.

@hikalkan
Copy link
Member Author

hikalkan commented Sep 8, 2020

@hikalkan hikalkan closed this as completed Sep 8, 2020
@hikalkan hikalkan reopened this Sep 8, 2020
@realLiangshiwei
Copy link
Member

wait for #5334, #5259 merge

@hikalkan
Copy link
Member Author

hikalkan commented Sep 9, 2020

@realLiangshiwei they are merged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants