Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group features on the feature management modal (MVC UI) #5329

Closed
hikalkan opened this issue Sep 7, 2020 · 2 comments · Fixed by #5334
Closed

Group features on the feature management modal (MVC UI) #5329

hikalkan opened this issue Sep 7, 2020 · 2 comments · Fixed by #5334

Comments

@hikalkan
Copy link
Member

hikalkan commented Sep 7, 2020

Just like the permissions, features also has group system. Example:

using FeaturesDemo.Localization;
using Volo.Abp.Features;
using Volo.Abp.Localization;
using Volo.Abp.Validation.StringValues;

namespace FeaturesDemo
{
    public class MyFeatureDefinitionProvider : FeatureDefinitionProvider
    {
        public override void Define(IFeatureDefinitionContext context)
        {
            var myGroup = context.AddGroup("MyApp");

            var reportingFeature = myGroup.AddFeature(
                "MyApp.Reporting",
                defaultValue: "false",
                displayName: LocalizableString.Create<FeaturesDemoResource>("Reporting"),
                valueType: new ToggleStringValueType()
            );

            reportingFeature.CreateChild(
                "MyApp.PdfReporting",
                defaultValue: "false",
                displayName: LocalizableString.Create<FeaturesDemoResource>("PdfReporting"),
                valueType: new ToggleStringValueType()
            );

            reportingFeature.CreateChild(
                "MyApp.ExcelReporting",
                defaultValue: "false",
                displayName: LocalizableString.Create<FeaturesDemoResource>("ExcelReporting"),
                valueType: new ToggleStringValueType()
            );

            myGroup.AddFeature(
                "MyApp.MaxProductCount",
                defaultValue: "10",
                displayName: LocalizableString.Create<FeaturesDemoResource>("MaxProductCount"),
                valueType: new FreeTextStringValueType(new NumericValueValidator(0, 1000000))
            );
        }
    }
}

However, current feature management modal doesn't implement this.

We should implement it just like the permission management modal, with tabs on the left side. This is a continuation of the #5327

Do this also for the SaaS module.

@realLiangshiwei
Copy link
Member

The saas module does not need to be modified. It directly uses the page of the feature management module

@hikalkan
Copy link
Member Author

hikalkan commented Sep 9, 2020

@realLiangshiwei you are definitely right! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants