UserId/UserName not present in some AbpSecurityLogs

[olicooper]

I think this record was a host admin logging in (through the angular client) so I don't expect the tenant information to be present. But I expected to at least see the UserId/UserName filled in? Is this a bug or intentional?

We're on ABP v3.1.0-preview20200813

[maliming]

• Steps needed to reproduce the problem.

[olicooper]

Okay, I don't have much to go on but I will see what I can do. So do you think these fields should always be populated?

1. All users have passwords, they are not external logins.
2. They may have already had a valid access_token and not actually 'logged in' as such?
3. Using the password flow to submit login, with Angular 10 and angular-oauth2-oidc v10

[olicooper]

It looks like the normal password flow causes this issue to occur for me. I simply logged in on the angular client.
I noticed your fix #5121 - could we also populate the UserName field for UserLoginFailureEvent too?
Is it also possible to populate the ClientId like with the Logout Actions?

It might also be possible to populate the UserId field for the LoginSucceeded event because the UserId is already fetched in the code:

abp/modules/identityserver/src/Volo.Abp.IdentityServer.Domain/Volo/Abp/IdentityServer/AspNetIdentity/AbpResourceOwnerPasswordValidator.cs

Line 74 in 3e05d01

var sub = await UserManager.GetUserIdAsync(user);

[maliming]

hi @olicooper

I will recheck this function today. : )