Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABP CLI command: update does not run yarn (or npm i) #4598

Closed
gdlcf88 opened this issue Jul 2, 2020 · 1 comment
Closed

ABP CLI command: update does not run yarn (or npm i) #4598

gdlcf88 opened this issue Jul 2, 2020 · 1 comment
Assignees
Milestone

Comments

@gdlcf88
Copy link
Contributor

gdlcf88 commented Jul 2, 2020

@yekalkan This problem is related to the commit: d8a8d0f#diff-e057c9d8e81acf62fac9f55ea6980e05R75-R79

if (includePreviews)
{
await CreateNpmrcFileAsync(Path.GetDirectoryName(file.Key));
RunNpmInstall(fileDirectory);
}
else if (switchToStable)
{
await DeleteNpmrcFileAsync(Path.GetDirectoryName(file.Key));
RunYarn(fileDirectory);
}

private async Task UpdateNpmPackages(string directory)
{
await _npmPackagesUpdater.Update(directory);
}

RunYarn() and RunNpmInstall() will never be executed, because includePreviews and switchToStable is always false.

This is my logs:

[22:57:49 INF] Checking installed npm global packages...
[22:57:58 INF] Updated @abp/aspnetcore.mvc.ui.theme.basic to ~3.0.1 in \sample\MyProject\aspnet-core\src\MyProject.Web\package.json.
[22:57:59 INF] Running Gulp on D:\Projects\EasyAbp\EasyAbp.GiftCardManagement\sample\MyProject\aspnet-core\src\MyProject.Web\
[�[90m22:58:04�[39m] Using gulpfile D:\Projects\EasyAbp\EasyAbp.GiftCardManagement\sample\MyProject\aspnet-core\src\MyProject.Web\gulpfile.js
[�[90m22:58:04�[39m] Starting 'default'...
[�[90m22:58:07�[39m] Finished 'default' after 3.58 s
@yekalkan yekalkan self-assigned this Jul 2, 2020
@yekalkan yekalkan added this to the 3.1 milestone Jul 2, 2020
yekalkan added a commit that referenced this issue Jul 2, 2020
yekalkan added a commit that referenced this issue Jul 2, 2020
@yekalkan
Copy link
Member

yekalkan commented Jul 2, 2020

I've fixed. Thanks for informing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants