Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to change property lenghts on runtime #4139

Closed
hikalkan opened this issue May 29, 2020 · 1 comment
Closed

Find a way to change property lenghts on runtime #4139

hikalkan opened this issue May 29, 2020 · 1 comment

Comments

@hikalkan
Copy link
Member

See this commit: 5f6c5e8

It is checking the DBMS and using diffrent lengths for the table fields (otherwise there are problems for the related DBMS). However, the module code (entity, DTOs... etc) still using the contants (like AuditLogConsts.MaxExceptionsLength). So, application code allows higher length than the configured one on the database which may cause runtime errors.
@hikalkan hikalkan added this to the 3.0 milestone May 29, 2020
@hikalkan hikalkan self-assigned this May 29, 2020
@hikalkan hikalkan mentioned this issue May 29, 2020
Closed
@hikalkan hikalkan mentioned this issue Jun 25, 2020
Closed
@hikalkan
Copy link
Member Author

Will use DynamicStringLengthAttribute and change consts to statics (with public setter). See #4496 and #4497

@hikalkan hikalkan removed this from the 3.0 milestone Jun 25, 2020
@hikalkan hikalkan removed their assignment Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hikalkan