Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuditLogActionConsts.MaxParametersLength is too short. #3102

Closed
Rwing opened this issue Mar 13, 2020 · 10 comments
Closed

AuditLogActionConsts.MaxParametersLength is too short. #3102

Rwing opened this issue Mar 13, 2020 · 10 comments

Comments

@Rwing
Copy link
Contributor

Rwing commented Mar 13, 2020


Parameters = actionInfo.Parameters.Length > AuditLogActionConsts.MaxParametersLength ? "" : actionInfo.Parameters;

In some cases it's to short, should we change it to MAX ?

@maliming
Copy link
Member

@hikalkan What do you think?

@maliming maliming added this to the 2.3 milestone Mar 13, 2020
@Rwing
Copy link
Contributor Author

Rwing commented Mar 13, 2020

@maliming Is there any workaround to this problem now? I have a system in production that needs to be solved

@maliming
Copy link
Member

Is there any workaround to this problem now?

Unfortunately No.

@Rwing
Copy link
Contributor Author

Rwing commented Mar 13, 2020

So sad 😢

@maliming
Copy link
Member

You can download the audit-logging's source code and change it, then release a temporary package to solve this problem.

@Rwing
Copy link
Contributor Author

Rwing commented Mar 14, 2020

Okay, it's a temporary solution.
But I want waitting for @hikalkan to decide how to solve this problem。

@maliming maliming removed this from the 2.3 milestone Mar 14, 2020
@Rwing
Copy link
Contributor Author

Rwing commented Mar 26, 2020

Is there any plan to resovle this?

@jortygu
Copy link

jortygu commented Apr 7, 2020

just like DbTablePrefix,can cusomize MaxParametersLength

@hikalkan
Copy link
Member

I will work on this in the next milestone to see if we can provide a simple way to make all such constants changeable.

@hikalkan
Copy link
Member

There are two main cases;

  • Making the length consts has an advantage: We can use it on data annotation properties on create/update DTOs. I know, MaxParametersLength is not something like that, but speaking in general.
  • 2000+ is not working for Oracle.

However, I will try to resolve this problem with #4139
It will probably a breaking change (an easy-to-fix one, hopefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants