Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the MicroserviceDemo to the abp-samples repository #3892

Closed
hikalkan opened this issue May 10, 2020 · 3 comments
Closed

move the MicroserviceDemo to the abp-samples repository #3892

hikalkan opened this issue May 10, 2020 · 3 comments
Assignees
@gterdem
Labels
abp-samples effort-5 enhancement
Milestone
3.1

Comments

@hikalkan
Copy link
Member

I think it is mature enough to be able to use stable, released NuGet packages instead of local framework references. This will make it faster to run, debug and easy to deploy.
@hikalkan hikalkan added this to the 2.9 milestone May 10, 2020
@hikalkan hikalkan modified the milestones: 2.9, 3.0, 3.1 May 30, 2020
@gterdem gterdem mentioned this issue Jul 2, 2020
Merged
@gterdem
Copy link
Contributor

gterdem commented Jul 3, 2020

Fixed via PR#15.

@gterdem gterdem closed this as completed Jul 3, 2020
@maliming
Copy link
Member

maliming commented Jul 6, 2020

hi @gterdem Should we remove it in abp?
https://github.com/abpframework/abp/tree/dev/samples/MicroserviceDemo

@gterdem
Copy link
Contributor

gterdem commented Jul 6, 2020

Hey @maliming, yet it can be removed from abp.

@gterdem gterdem mentioned this issue Jul 6, 2020
Closed
maliming added a commit that referenced this issue Jul 6, 2020
@maliming
Remove MicroserviceDemo.
fe7f593 
#3892
@maliming maliming mentioned this issue Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gterdem gterdem

Labels
abp-samples effort-5 enhancement
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
4 participants
@gterdem @hikalkan @maliming @AkinSabriCam