Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement: Breaking Change for Volo.Abp.Http.Client.IdentityModel package #2960

Closed
hikalkan opened this issue Mar 3, 2020 · 3 comments
Closed
Milestone

Comments

@hikalkan
Copy link
Member

hikalkan commented Mar 3, 2020

Volo.Abp.Http.Client.IdentityModel package was using Microsoft.NET.Sdk.Web SDK and it was using .net core 3.1. #2867 removes this dependency so it can be usable by non .net core projects too (like Xamarin and full .net framework).

This PR moves web depended functionality to Volo.Abp.Http.Client.IdentityModel.Web package, which can be a breaking change for existing applications.

Fortunately it is easy to fix.

  1. For web projects depend on the Volo.Abp.Http.Client.IdentityModel package;
  • Replace the Volo.Abp.Http.Client.IdentityModel reference by the Volo.Abp.Http.Client.IdentityModel.Web reference.
  • Replace the dependency typeof(AbpHttpClientIdentityModelModule) to typeof(AbpHttpClientIdentityModelWebModule) for your related module class.
  1. For console applications depend on the Volo.Abp.Http.Client.IdentityModel package;
  • Add Microsoft.Extensions.Hosting package reference to your .csproj file:
<PackageReference Include="Microsoft.Extensions.Hosting" Version="3.1.2" />

Reason: Because the hosting services were coming indirectly from the Volo.Abp.Http.Client.IdentityModel dependency and now we should manually use this package.

Example change set: 7d94050

@viewtance
Copy link

viewtance commented Mar 5, 2020

The Volo.Abp.Http.Client.IdentityModel.Web package not published yet?

@ismcagdas
Copy link
Member

@viewtance yes it seems like there is problem about this. We will publish it in a short time.

@hikalkan
Copy link
Member Author

hikalkan commented Mar 6, 2020

It is available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants