Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra route attribute of FindTenantByNameAsync cause warning. #2765

Closed
gdlcf88 opened this issue Feb 5, 2020 · 0 comments · Fixed by #2766
Closed

Extra route attribute of FindTenantByNameAsync cause warning. #2765

gdlcf88 opened this issue Feb 5, 2020 · 0 comments · Fixed by #2766
Assignees
@maliming
Labels
effort-0.5
Milestone
2.1

Comments

@gdlcf88
Copy link
Contributor

gdlcf88 commented Feb 5, 2020

abp/framework/src/Volo.Abp.AspNetCore.Mvc.UI.MultiTenancy/Pages/Abp/MultiTenancy/AbpTenantController.cs

Line 20 in 3705594

[Route("find-tenant/{name}")] //TODO: Remove on v1.0

Maybe this line should be deleted, or it will throw warning:

2020-02-06 04:11:58.460 +08:00 [WRN] Controller 'AbpTenant' contains more than one action with name 'FindTenantByNameAsyncByName' for module 'app'. Ignored: System.Threading.Tasks.Task`1[Volo.Abp.AspNetCore.Mvc.MultiTenancy.FindTenantResultDto] FindTenantByNameAsync(System.String)
@maliming maliming self-assigned this Feb 6, 2020
@maliming maliming added this to the 2.1 milestone Feb 6, 2020
maliming added a commit that referenced this issue Feb 6, 2020
@maliming
Remove find-tenant router.
b146221 
Resolve #2765
@maliming maliming mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
effort-0.5
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Remove find-tenant router. abpframework/abp
2 participants
@maliming @gdlcf88