FullAuditedAggregateRootWithUser generic type wrong constraint

[RayMMond]

Anyone please tell me why FullAuditedAggregateRootWithUser need TUser to inherited from IEntity<long> while IUser interface using IEntity<Guid>?

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Auditing/FullAuditedAggregateRootWithUser.cs

Lines 11 to 12 in 654eeed

	public abstract class FullAuditedAggregateRootWithUser<TUser> : FullAuditedAggregateRoot, IFullAuditedObject<TUser>
	where TUser : IEntity<long>

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Auditing/FullAuditedAggregateRootWithUser.cs

Lines 30 to 31 in 654eeed

	public abstract class FullAuditedAggregateRootWithUser<TKey, TUser> : FullAuditedAggregateRoot<TKey>, IFullAuditedObject<TUser>
	where TUser : IEntity<long>

abp/modules/users/src/Volo.Abp.Users.Domain/Volo/Abp/Users/IUser.cs

Line 8 in 42f37c5

public interface IUser : IAggregateRoot<Guid>, IMultiTenant

[maliming]

I am also confused about this.

@hikalkan can you explain it. Thanks.

[acjh]

I suppose that is because FullAuditedAggregateRootWithUser was committed on 14 Mar 2018 (2339fab#diff-88bc7789a4b0b95478b3bb69f9f1fc29), before @hikalkan decided to go with Guid for TKey of IUser on 20 Jun 2018 (745d891#diff-99e4bec2857b169bc53dbd6d309560c4).

FullAuditedAggregateRootWithUser may have been overlooked because it is not used anywhere (https://github.com/abpframework/abp/search?q=FullAuditedAggregateRootWithUser) and the two classes are in different projects — FullAuditedAggregateRootWithUser in the framework and IUser in the users module.

I believe we should update it in FullAuditedAggregateRootWithUser.

[hikalkan]

@acjh you are right. FullAuditedAggregateRootWithUser classes have never been used and forgotten :) I will update them.

[hikalkan]

BTW, we don't suggest to use this base class since it breaks one of the Aggregate design rules: "Don't add navigation properties between aggregates, use Id instead".

But you know not everyone has to perfectly design DDD based apps. If you are using EF Core, it is a common habit to add such navigation properties.

[RayMMond]

Thanks for the extra explanation about DDD :) @hikalkan

[hikalkan]

You're welcome :)

[xkaede]

hi @hikalkan
AuditedAggregateRootWithUser and FullAuditedEntityWithUser are wrong too.

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Auditing/AuditedAggregateRootWithUser.cs

Line 12 in 251a8d2

where TUser : IEntity<long>

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Entities/Auditing/FullAuditedEntityWithUser.cs

Line 12 in 251a8d2

where TUser : IEntity<long>

by the way, I am using CQRS pattern. and I find use *EntityWithUser in Query model will be convenient.
so I still need these base classes.