Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing PrimeNG components from Angular modules #2537

Closed
mehmet-erim opened this issue Jan 3, 2020 · 0 comments · Fixed by #2606
Closed

Removing PrimeNG components from Angular modules #2537

mehmet-erim opened this issue Jan 3, 2020 · 0 comments · Fixed by #2606
Assignees
@thediaval @mehmet-erim
Labels
ui-angular
Milestone
2.0

Comments

@mehmet-erim
Copy link
Contributor

mehmet-erim commented Jan 3, 2020 •
edited
Loading

We decided to eliminate all PrimeNG imports and declarations from Angular modules. Because the new version of PrimeNG has a lot of breaking changes.

The development we will make related to this issue won't cause any breaking changes. You will be able to continue using PrimeNG, ConfirmationService and ToasterService as like before.

Three components will be developed:

  • Table component (new)
  • Pagination component (new)
  • Loading component (new)
  • Loading directive (new)
  • Confirmation component
  • Toaster component
@mehmet-erim mehmet-erim added this to the 2.0 milestone Jan 3, 2020
mehmet-erim added a commit that referenced this issue Jan 3, 2020
@mehmet-erim
feat(theme-shared): create paginator component
383e3e1 
#2537
mehmet-erim added a commit that referenced this issue Jan 3, 2020
@mehmet-erim
feat(theme-shared): create table component
a262ac1 
#2537
mehmet-erim added a commit that referenced this issue Jan 6, 2020
@mehmet-erim
refactor(theme-shared): improve table scrolling user experience
746d156 
#2537
mehmet-erim added a commit that referenced this issue Jan 6, 2020
@mehmet-erim
feat(theme-shared): add loading directive and component
ea2eeb3 
#2537
mehmet-erim added a commit that referenced this issue Jan 6, 2020
@mehmet-erim
refactor(theme-shared): add trackByFn
a9df4c7 
#2537
mehmet-erim added a commit that referenced this issue Jan 7, 2020
@mehmet-erim
feat(theme-shared): add empty template to table component
9d448ef 
#2537
mehmet-erim added a commit that referenced this issue Jan 7, 2020
@mehmet-erim
feat(theme-shared): remove prime table instance from table sort direc…
e92e164 
…tive and add abp table instance

#2537
mehmet-erim added a commit that referenced this issue Jan 7, 2020
@mehmet-erim
feat(theme-shared): add hover to table rows
6db7d50 
#2537
mehmet-erim added a commit that referenced this issue Jan 7, 2020
@mehmet-erim
chore(theme-shared): rename paginator to pagination
55f5d8f 
#2537
mehmet-erim added a commit that referenced this issue Jan 7, 2020
@mehmet-erim
tests(theme-shared): add pagination.component.spec
900d0b2 
#2537
mehmet-erim added a commit that referenced this issue Jan 8, 2020
@mehmet-erim
tests(theme-shared): add loading.directive.spec
475d3bb 
#2537
mehmet-erim added a commit that referenced this issue Jan 8, 2020
@mehmet-erim
refactor(theme-shared): change td element to div
49a14b9 
#2537
mehmet-erim added a commit that referenced this issue Jan 9, 2020
@mehmet-erim
tests(theme-shared): add table.component.spec
1b2476a 
#2537
mehmet-erim added a commit that referenced this issue Jan 9, 2020
@mehmet-erim
refactor(theme-shared): change the table row hover style
4f3df42 
#2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
feat(theme-shared): add toast-container component
78e4429 
related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
refactor(theme-shared): change toaster types and interfaces
e8345ef 
related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
feat(theme-shared): import toast-container component to module
13ed5e0 
related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
refactor(theme-shared): use toast-container instead of toast componen…
dd93bee 
…t in layouts

related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
refactor(theme-shared): add new toaster service
e8ac235 
related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
refactor(theme-shared): add new confirmation component and its styles
21d747e 
related issue: #2537
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
refactor(theme-shared): add new confirmation types and interfaces
009bde8 
related issue: #2537
@thediaval thediaval mentioned this issue Jan 9, 2020
Merged
thediaval added a commit that referenced this issue Jan 9, 2020
@thediaval
feat(theme-shared): add clear toasts by key functionality
72fee03 
related issue: #2537
thediaval added a commit that referenced this issue Jan 10, 2020
@thediaval
feat(theme-basic): add toast-container component to layout
6217cd1 
related issue: #2537
thediaval added a commit that referenced this issue Jan 10, 2020
@thediaval
refactor(theme-shared): change opacity and icon size
6b3d743 
related issue: #2537
thediaval added a commit that referenced this issue Jan 10, 2020
@thediaval
fix(theme-shared): correct css class names for confirmation icons
835a17b 
related issue: #2537
thediaval added a commit that referenced this issue Jan 10, 2020
@thediaval
feat(theme-shared): change icon color to severity color
f0158d4 
related issue: #2537
thediaval added a commit that referenced this issue Jan 10, 2020
@thediaval
fix(theme-shared): change z-index of container element
3e40fc3 
related issue: #2537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thediaval thediaval

@mehmet-erim mehmet-erim

Labels
ui-angular
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

feat(theme-shared): new toast and confirmation components abpframework/abp
2 participants
@thediaval @mehmet-erim