Merge pull request #7148 from olicooper/pr/angular-auth-guard

angular: Fix AuthGuard returning 'true' when user not authorized
abpframework · Jan 12, 2021 · fc98098 · fc98098
2 parents 051f1f3 + 50be0e4
commit fc98098
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/npm/ng-packs/packages/core/src/lib/guards/auth.guard.ts b/npm/ng-packs/packages/core/src/lib/guards/auth.guard.ts
@@ -17,6 +17,6 @@ export class AuthGuard implements CanActivate {
     }
 
     this.authService.initLogin();
-    return true;
+    return false;
   }
 }
diff --git a/npm/ng-packs/packages/core/src/lib/tests/auth.guard.spec.ts b/npm/ng-packs/packages/core/src/lib/tests/auth.guard.spec.ts
@@ -26,7 +26,7 @@ describe('AuthGuard', () => {
     spectator.inject(OAuthService).hasValidAccessToken.andReturn(false);
     const initLoginSpy = jest.spyOn(authService, 'initLogin');
 
-    expect(guard.canActivate()).toBe(true);
+    expect(guard.canActivate()).toBe(false);
     expect(initLoginSpy).toHaveBeenCalled();
   });
 });