Merge pull request #7361 from /issues/7345

Cli: Remove warnings from version list output
abpframework · Jan 21, 2021 · da59dbc · da59dbc
2 parents 5b0b015 + fa1457a
commit da59dbc
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/NpmPackagesUpdater.cs
@@ -345,11 +345,20 @@ protected virtual void RunNpmInstall(string fileDirectory)
 
         protected virtual List<string> GetPackageVersionList(JProperty package)
         {
-            var versionListAsJson = CmdHelper.RunCmdAndGetOutput($"npm show {package.Name} versions");
+            var output = CmdHelper.RunCmdAndGetOutput($"npm show {package.Name} versions --json");
+
+            var versionListAsJson = ExtractVersions(output);
+
             return JsonConvert.DeserializeObject<string[]>(versionListAsJson)
                 .OrderByDescending(SemanticVersion.Parse, new VersionComparer()).ToList();
         }
 
+        protected virtual string ExtractVersions(string output)
+        {
+            var arrayStart = output.IndexOf('[');
+            return output.Substring(arrayStart,  output.IndexOf(']') - arrayStart + 1);
+        }
+
         protected virtual bool SpecifiedVersionExists(string version, JProperty package)
         {
             var versionList = GetPackageVersionList(package);