Optimization& refactor: Move localizer inside the validation control

abpframework · Dec 28, 2019 · c010c56 · c010c56
1 parent d153a6b
commit c010c56
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/...c/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Dtos/LimitedResultRequestDto.cs b/...c/Volo.Abp.Ddd.Application.Contracts/Volo/Abp/Application/Dtos/LimitedResultRequestDto.cs
@@ -32,13 +32,20 @@ public class LimitedResultRequestDto : ILimitedResultRequest, IValidatableObject
 
         public virtual IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
         {
-            var l = validationContext.GetService(typeof(IStringLocalizer<AbpDddResource>)) as IStringLocalizer<AbpDddResource>;
-
             if (MaxResultCount > MaxMaxResultCount)
             {
+                var localizer = (IStringLocalizer<AbpDddResource>)validationContext
+                    .GetService(typeof(IStringLocalizer<AbpDddResource>));
+
                 yield return new ValidationResult(
-                    errorMessage:l?["MaxResultCountExceededExceptionMessage", nameof(MaxResultCount), MaxMaxResultCount, typeof(LimitedResultRequestDto).FullName, nameof(MaxMaxResultCount)],
-                    new []{nameof(MaxResultCount)});
+                    localizer[
+                        "MaxResultCountExceededExceptionMessage", 
+                        nameof(MaxResultCount),
+                        MaxMaxResultCount, 
+                        typeof(LimitedResultRequestDto).FullName, 
+                        nameof(MaxMaxResultCount)
+                    ],
+                    new[] { nameof(MaxResultCount) });
             }
         }
     }