Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akin/upgraded all samples and tested all #14

Merged
merged 21 commits into from
Jul 2, 2020

Conversation

AkinSabriCam
Copy link

@AkinSabriCam AkinSabriCam requested a review from hikalkan July 1, 2020 18:50
@AkinSabriCam
Copy link
Author

AkinSabriCam commented Jul 1, 2020

Rebuild all doesn't work because Authentication-Customization sample has bug.
The problem is not related with upgrading sample

You can check this issue about this problem. abpframework/abp#4571

@hikalkan hikalkan merged commit 9d5d790 into master Jul 2, 2020
@hikalkan hikalkan deleted the akin/upgraded-all-samples-and-tested-all branch July 2, 2020 06:30
@gterdem
Copy link
Contributor

gterdem commented Jul 3, 2020

@AkinSabriCam rebuild all doesn't work not only because of Authentication-Customization sample. It was failing because of no longer public override method of TestBase/Security/FakeCurrentPrincipalAccessor which has been updated with abpframework/abp@7846c90.

Keep on mind that you can check github build actions like: https://github.com/abpframework/abp-samples/runs/829471172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants