Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate debian-oval and ubuntu importer #740

Merged
merged 8 commits into from
Oct 20, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented May 19, 2022

Signed-off-by: Tushar Goel [email protected]

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good... do you mind to rebase on the latest code?

@TG1999 TG1999 force-pushed the migrate/debian_oval branch 2 times, most recently from 13e58a5 to 8551476 Compare June 16, 2022 12:19
@TG1999
Copy link
Contributor Author

TG1999 commented Jun 16, 2022

Rebased!

@TG1999 TG1999 force-pushed the migrate/debian_oval branch 4 times, most recently from b47f252 to a5354cd Compare June 16, 2022 15:37
@pombredanne
Copy link
Member

@TG1999 let's rebase one more time before merging!

@TG1999 TG1999 force-pushed the migrate/debian_oval branch from a5354cd to 94c613d Compare September 12, 2022 14:15
@TG1999 TG1999 force-pushed the migrate/debian_oval branch from 000d87d to 8f98e14 Compare October 10, 2022 16:54
@TG1999 TG1999 added this to the v31.0 milestone Oct 11, 2022
@TG1999 TG1999 force-pushed the migrate/debian_oval branch from df9faf8 to 22e86ec Compare October 19, 2022 09:44
@TG1999 TG1999 requested a review from pombredanne October 19, 2022 09:54
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a small nit... Please merge!

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 force-pushed the migrate/debian_oval branch from 57bd8a7 to 6d7905c Compare October 20, 2022 10:45
@TG1999 TG1999 merged commit 8eaa86a into aboutcode-org:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate ubuntu importer to importer-improver model debian_oval importer - improver migration
2 participants