Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate debian importer to importer-improver model #723

Merged
merged 1 commit into from
May 17, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented May 4, 2022

Signed-off-by: Tushar Goel [email protected]

@TG1999 TG1999 marked this pull request as draft May 4, 2022 14:43
@TG1999 TG1999 force-pushed the migrate/debian branch from 905aee9 to 786dd04 Compare May 5, 2022 13:37
@TG1999 TG1999 marked this pull request as ready for review May 5, 2022 13:37
@TG1999 TG1999 force-pushed the migrate/debian branch 5 times, most recently from 6225c34 to 23001d2 Compare May 5, 2022 17:42
@TG1999 TG1999 linked an issue May 5, 2022 that may be closed by this pull request
@TG1999 TG1999 force-pushed the migrate/debian branch 3 times, most recently from 2b69232 to b7fc24d Compare May 6, 2022 11:43
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments for your review!

vulnerabilities/helpers.py Outdated Show resolved Hide resolved
vulnerabilities/helpers.py Outdated Show resolved Hide resolved
vulnerabilities/helpers.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
@TG1999 TG1999 force-pushed the migrate/debian branch 2 times, most recently from e5655dd to de0682b Compare May 11, 2022 12:09
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! here are few comments for your consideration.

vulnerabilities/helpers.py Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Show resolved Hide resolved
vulnerabilities/importers/debian.py Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
@TG1999
Copy link
Contributor Author

TG1999 commented May 17, 2022

@pombredanne addressed all comments on this PR, please let me know if this looks good

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TG1999 TG1999 merged commit 1ed87cd into aboutcode-org:main May 17, 2022
@keshav-space keshav-space linked an issue Aug 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debian_oval importer - improver migration debian importer - improver migration
2 participants