Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend to_dict function for inferences #702

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Apr 19, 2022

Also return an empty list instead of returning None when there is no advisory data passed in get_inferences

Signed-off-by: Tushar Goel [email protected]

@TG1999 TG1999 requested review from pombredanne and Hritik14 April 19, 2022 13:31
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also return an empty list instead of returning None when there is no advisory data passed in get_inferences

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 force-pushed the default-improver-follow-up-pr branch from b24a271 to 0c360ee Compare April 21, 2022 15:17
@pombredanne pombredanne changed the title Ammend to_dict function for inferences Amend to_dict function for inferences Apr 21, 2022
@TG1999 TG1999 merged commit 6bebd6b into aboutcode-org:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants