-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect go vulnerabilities from github api #578
Conversation
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
fetching release_date for each version is very slow, commenting out those lines will make it a lot faster |
@sify21 Thank you ++ for this! Let me review this in details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sify21 .
Most of the stuff looks very good. Thanks for updating the type hints btw.
As an improvement in clarity and readability, maybe restructure the GoproxyVersionAPI
such that:
The fetch
method only does one thing, it should only fetch and update the cache. It shouldn't
- Do low level stuff on modifying the obtained
version_info
. - Construct the api url.
Maybe create separte functions/methods for above two.
Also some unittests would be helpful.
Signed-off-by: 司芳源 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This would be good to merge after
- Adding some comments on as suggested inline. Without prior knowledge it's hard to understand the intent of the code.
- Add some test cases or just examples in a doc string
trim_url_path
andescape_path
methods.
Signed-off-by: 司芳源 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do you think you could add a few unit tests before we merge?
Co-authored-by: Philippe Ombredanne <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Hi @pombredanne, I added some tests. I don't know how to resolve conflicts on github, should I pull the latest changes and resolve the conflicts on my fork? |
yes, you need to resolve these git conflicts locally, eventually rebasing and amending as needed and then force push to your branch once this is done |
@pombredanne merged |
Thanks! There is a merge commit that's making the DCO bot unhappy... I will ignore this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. Do you mind to run black to reformat your code?
make black
should be enough
Signed-off-by: 司芳源 <[email protected]>
@pombredanne reformatted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sify21 I have added a few extra comments for your consideration.
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
Signed-off-by: 司芳源 <[email protected]>
@sify21 As the development in this branch is going on and we wanted to move ahead with #476, rebasing/merging this with/from main will likely cause merge conflicts. Please accept the incoming changes for the import statements. |
Signed-off-by: 司芳源 <[email protected]>
@Hritik14 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isort fails... I am running isort and merging now!
Thank you ++
try to fix #466