Refactor package_managers #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use uniform names and prototypes for `fetch` function. Remove unnecessary checks. Re-use sessions Signed-off-by: Hritik Vijay <[email protected]>
The code for `load_api` was repetitive and used in all subclasses of VersionAPI, it is better suited in the parent class. `fetch` method is also now consistent and defined as an abstract method in the base class. Python ABC is not used as different implementations of `load_api` and `fetch` are allowed as done in DebianVersionAPI Signed-off-by: Hritik Vijay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #492
Use uniform names and prototypes for
fetchmethod.Remove unnecessary checks. Re-use sessions.
I've removed
endpointargument from GitHubTagsAPI, I did not find a use for it at the current stage. Also, thefetchmethod is only called for the pkg which is not already in cache, so other checks appeared redundant. Please correct me if I am wrong.Move load_api to parent class and refactor imports
The code for
load_apiwas repetitive and used in all subclasses ofVersionAPI, it is better suited in the parent class.
fetchmethod isalso now consistent and defined as an abstract method in the base class.
Python ABC is not used as different implementations of
load_apiandfetchare allowed as done in DebianVersionAPISigned-off-by: Hritik Vijay [email protected]