Misc fixes for deploying vulnerablecode on a container platform #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to print stack traces on the stdout Best practice would be to integrate with sentry, but at least print the stack trace is helpful when trying to deploy this Signed-off-by: Pierre Tardy <[email protected]>
Signed-off-by: Pierre Tardy <[email protected]>
sbs2001
requested changes
Mar 30, 2021
| @@ -26,6 +26,7 @@ | |||
|
|
|||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = False | |||
| DEBUG_PROPAGATE_EXCEPTIONS = True | |||
There was a problem hiding this comment.
Enabling this when the DJANGO_DEV=1 env variable is also set is probably better idea.
There was a problem hiding this comment.
well, the whole point is to stil enable this when not using DJANGO_DEV.
If we don't have this in prod, we have absolutely no visibility in case of error 500.
This setting allows to propagate the exception to the base logger, and thus to display them in runserver's stdout.
I dont think there are security implication to this.
If we are in DJANGO_DEV, then DEBUG is true, and exception is printed in the browser along with debug UI which is really insecure.
sbs2001
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my last few fixes for today.
We can now call vulnerable code enterprise ready ;)