Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for nginx importer #643

Closed
pombredanne opened this issue Mar 11, 2022 · 1 comment
Closed

Add tests for nginx importer #643

pombredanne opened this issue Mar 11, 2022 · 1 comment
Assignees
@Hritik14

Comments

@pombredanne
Copy link
Member

We have very few of these
@pombredanne pombredanne mentioned this issue Mar 11, 2022
Closed
31 tasks
@pombredanne
Copy link
Member Author

@Hritik14 :)

pombredanne added a commit that referenced this issue Apr 11, 2022
@pombredanne
Add tests for nginx importer
177c4c9 
* Refactor code for testability
* Move complex doctest to plain test code
* Ensure that there is Reference for a CVE
* Use object (NginxAdvisory namedtuple) rather than plain tuple of
  values when passing results around

Reference: #643
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne added a commit that referenced this issue Apr 11, 2022
@pombredanne
Add test and refine nginx code
985ad19 
* Do not use asyncio. Use the new simpler GitHubTagsAPI
* Extract fetching tags in a fetch_nginx_version_from_git_tags() method
* Add and improve importer and improver tests

Reference: #643
Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne added a commit that referenced this issue Apr 11, 2022
@pombredanne
Test nginx improver get_inferences() method
da7faf7 
* Add AdvisoryData.to_dict() methods as convenience for testing
* Split NginxBasicImprover.get_inferences() in tow functions to ease
  testing

Reference: #643
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne pombredanne mentioned this issue Apr 11, 2022
Merged
@TG1999 TG1999 closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hritik14 Hritik14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pombredanne @Hritik14 @TG1999