Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor importer_yielder.py #501

Closed
Hritik14 opened this issue Jul 15, 2021 · 1 comment · Fixed by #600
Closed

refactor importer_yielder.py #501

Hritik14 opened this issue Jul 15, 2021 · 1 comment · Fixed by #600
Assignees
@Hritik14
Labels
core debt import-improver-migration Priority: medium
Milestone
v30.0

Comments

@Hritik14
Copy link
Collaborator

Do we really need this file ? Could the importer classes help enclosing these information ?
@pombredanne can you shed a little more light here ?

via https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-thursday-2021-07-15-at-1200-utc
@Hritik14
Copy link
Collaborator Author

Dumping importer_yielder

  • Simply store data source as concrete lists
  • Don't store configuration or last run, maybe we can have better Log Importer Runs later. Ticket: Log Importer Runs #526

Consider: https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/__init__.py#L41

via https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-tuesday-2021-08-10-at-1400-utc

@sbs2001 sbs2001 added the debt label Aug 25, 2021
@Hritik14 Hritik14 self-assigned this Jan 26, 2022
Hritik14 added a commit to Hritik14/vulnerablecode that referenced this issue Jan 26, 2022
@Hritik14
Dump importer_yielder in favor of IMPORTER_REGISTRY
90fd963 
IMPORTER_REGISTRY is neater and does not do any magical string -> object
conversion. The registry looks more in sync with improvers.
Fixes: aboutcode-org#501

Signed-off-by: Hritik Vijay <[email protected]>
@Hritik14 Hritik14 mentioned this issue Jan 26, 2022
Merged
Hritik14 added a commit to Hritik14/vulnerablecode that referenced this issue Feb 5, 2022
@Hritik14
Dump importer_yielder in favor of IMPORTER_REGISTRY
edde7c5 
IMPORTER_REGISTRY is neater and does not do any magical string -> object
conversion. The registry looks more in sync with improvers.
Fixes: aboutcode-org#501

Signed-off-by: Hritik Vijay <[email protected]>
Hritik14 added a commit to Hritik14/vulnerablecode that referenced this issue Feb 5, 2022
@Hritik14
Dump importer_yielder in favor of IMPORTER_REGISTRY
7c3d7a8 
IMPORTER_REGISTRY is neater and does not do any magical string -> object
conversion. The registry looks more in sync with improvers.
Fixes: aboutcode-org#501

Signed-off-by: Hritik Vijay <[email protected]>
@Hritik14 Hritik14 added this to the v30.0 milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hritik14 Hritik14

Labels
core debt import-improver-migration Priority: medium
Projects
None yet
Milestone
v30.0
Development

Successfully merging a pull request may close this issue.

Dump importer_yielder in favor of IMPORTER_REGISTRY and drop Etags Hritik14/vulnerablecode
3 participants
@pombredanne @Hritik14 @sbs2001