-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ecosystem specific inclusions or exclusions #1550
base: main
Are you sure you want to change the base?
Conversation
Also ignore specific files paths containing metadata in ruby gems. Reference: #1438 Reference: #1476 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
99db098
to
88bc201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fine, the name "config.py" is too generic though for now.
scanpipe/config.py
Outdated
@@ -0,0 +1,115 @@ | |||
# SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we need a better name as this is not a general purpose configuration. It could be either:
ecosystem_config.py
- or better
d2d_config.py
as this is really focused on d2d for now, and may even need to be brought down one dir under/pipelines
scanpipe/config.py
Outdated
"""Configurations which are common across multiple ecosystems.""" | ||
|
||
ecosystem_option = "Default" | ||
purldb_package_extensions = [".zip", ".tar.gz", ".tar.xz"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fairly limited but OK as a default.
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Also ignore specific files paths containing metadata in ruby gems.
Reference: #1438
Reference: #1476