Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplication from rootfs/docker pipes checksum handling #2

Closed
pombredanne opened this issue Sep 11, 2020 · 0 comments
Closed

Remove code duplication from rootfs/docker pipes checksum handling #2

pombredanne opened this issue Sep 11, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@pombredanne
Copy link
Member

In the docker.py pipeline:

  1. the code dealing with sha1/md5 is duplicated
  2. it could be streamlined
@pombredanne pombredanne added the enhancement New feature or request label Sep 11, 2020
tdruez added a commit that referenced this issue Nov 18, 2020
@tdruez
Attempt #2 to make the travis script 3.x compatible #54
cb6321a 
Signed-off-by: Thomas Druez <[email protected]>
tdruez added a commit that referenced this issue Apr 13, 2021
@tdruez
Replace duplicated hash comparison code by a has_hash_diff function #2
d708973 
Signed-off-by: Thomas Druez <[email protected]>
@tdruez tdruez closed this as completed Apr 13, 2021
@tdruez tdruez mentioned this issue Aug 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdruez @pombredanne