Add new licenses and rules #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new Apache detection rule to handle overlap case found in SignalR such that no unknown is returned * add new Apache detection rule to handle non-standard notice found in SignalR to return a higher score Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
* ms-net-library-2018-11 newly found in SignalR at same older URL https://www.microsoft.com/web/webpi/eula/net_library_eula_ENU.htm This is a modification of the previous ms-net-library license but is not versioned by Microsft and found exactly at the same URL * also rename and update older version rules Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
* replaced by bsd-source-cod license Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
* improve detection based on SignalR scans with new rules and/or adding a stored relevance if needed Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
* Adssign unknown-license-reference to rules that were unknown by mistake Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
* improve detection based on SignalR repos scans with new rules and/or adding or updating the rule "relevance" as needed Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
* improve detection primarily for license file references and mostly for things from Microsoft Reported-by: Jonas Öberg @jonasob Signed-off-by: Philippe Ombredanne <[email protected]>
pombredanne
force-pushed
the
new-licenses-and-rules
branch
from
81f8091 to
0b971e1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1282 +/- ##
========================================
Coverage 84.12% 84.12%
========================================
Files 118 118
Lines 13037 13037
========================================
Hits 10967 10967
Misses 2070 2070
Continue to review full report at Codecov.
|
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
|
All green... merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a set of new and improved licenses and license detection rules based on and following a bug report by @jonasob for #1281 and other such as @DennisClark #1269